Skip to content

Add bottom padding to Sidebar #4993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2024
Merged

Add bottom padding to Sidebar #4993

merged 1 commit into from
Oct 11, 2024

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 11, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on a minor style adjustment in the Sidebar.tsx component, specifically changing a class name for padding.

Detailed summary

  • Changed the class name from pt-7 to py-7 in the <div> element, which alters the vertical padding applied to the sidebar.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 3:15pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 11, 2024 3:15pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 11, 2024 3:15pm
wallet-ui ⬜️ Skipped (Inspect) Oct 11, 2024 3:15pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 October 11, 2024 14:59 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1b559bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 11, 2024 14:59 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 11, 2024 14:59 Inactive
@MananTank MananTank marked this pull request as ready for review October 11, 2024 14:59
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 11, 2024
@MananTank Graphite App
Copy link
Member Author

MananTank commented Oct 11, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Oct 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.76%. Comparing base (982219a) to head (1b559bf).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4993   +/-   ##
=======================================
  Coverage   47.76%   47.76%           
=======================================
  Files        1058     1058           
  Lines       57290    57290           
  Branches     3945     3945           
=======================================
  Hits        27364    27364           
  Misses      29235    29235           
  Partials      691      691
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 982219a
packages 43.56% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.07 KB (0%) 842 ms (0%) 2.8 s (-23.82% 🔽) 3.6 s
thirdweb (cjs) 101.87 KB (0%) 2.1 s (0%) 7.5 s (+11.44% 🔺) 9.5 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 148 ms (+13.96% 🔺) 245 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 211 ms (+163.71% 🔺) 221 ms
thirdweb/react (minimal + tree-shaking) 17.24 KB (0%) 345 ms (0%) 555 ms (-56.57% 🔽) 900 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 11, 2024 •
edited by MananTank
Loading

Merge activity

@MananTank
Add bottom padding to Sidebar (#4993)
1b559bf 
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on modifying the padding class in the `Sidebar.tsx` component to enhance the layout.

### Detailed summary
- Changed the class from `pt-7` to `py-7` in the `div` element, which adjusts the vertical padding (top and bottom) instead of just the top padding.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 10-11-add_bottom_padding_to_sidebar branch from 07d6664 to 1b559bf Compare October 11, 2024 15:12
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 11, 2024 15:12 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 11, 2024 15:12 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 11, 2024 15:12 Inactive
@graphite-app graphite-app bot merged commit 1b559bf into main Oct 11, 2024
30 checks passed
@graphite-app graphite-app bot deleted the 10-11-add_bottom_padding_to_sidebar branch October 11, 2024 15:15
@vercel vercel bot temporarily deployed to Production – docs-v2 October 11, 2024 15:15 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 11, 2024 15:15 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 11, 2024 15:15 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls